[opensource-dev] Review Request: STORM-1044 Improved message template checking.

Merov Linden merov at lindenlab.com
Mon Mar 7 22:07:33 PST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/174/#review431
-----------------------------------------------------------

Ship it!


This seems to be good.

- Merov


On March 3, 2011, 2:20 p.m., Kelly Washington wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/174/
> -----------------------------------------------------------
> 
> (Updated March 3, 2011, 2:20 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Improved message template checking.
> * If no changes have been made to the message template the check is local only and trivial.
> * If changes have been made to the message template then compatibility is verified on the first build after the change instead of when they package.
> * Automated systems can use --force to force full message template verification
> 
> 
> This addresses bug STORM-1044.
>     http://jira.secondlife.com/browse/STORM-1044
> 
> 
> Diffs
> -----
> 
>   indra/cmake/TemplateCheck.cmake 3683d7c533f9 
>   indra/newview/CMakeLists.txt 3683d7c533f9 
>   scripts/messages/message_template.msg.sha1 PRE-CREATION 
>   scripts/template_verifier.py 3683d7c533f9 
> 
> Diff: http://codereview.secondlife.com/r/174/diff
> 
> 
> Testing
> -------
> 
> * Built the viewer and verified only the hash is checked.
> * Changed the template and verified full verification happens and a new sha1 saved.
> 
> 
> Thanks,
> 
> Kelly
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110308/b1dda3cb/attachment.htm 


More information about the opensource-dev mailing list