[opensource-dev] Review Request: partial fix for STORM-948: [crashhunters] meta-issue for bad_alloc exceptions

[Merov Linden]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/218/#review505
-----------------------------------------------------------


Need some clean up. Please review my comments.


indra/newview/llappviewer.cpp
<http://codereview.secondlife.com/r/218/#comment370>

    Aren't we in danger of immediate crash when called? If so, what happens if we return here? Do we let the app crash? Shouldn't we crash here immediately so we can identify in the stack trace which memory allocation produces the situation?



indra/newview/llviewerdisplay.cpp
<http://codereview.secondlife.com/r/218/#comment372>

    No clean up necessary in that catch {} block?



indra/newview/llviewertexturelist.cpp
<http://codereview.secondlife.com/r/218/#comment371>

    This global declaration doesn't follow naming convention. Also, it shouldn't be here but as a static member of the LLViewerTextureList class.


- Merov


On March 21, 2011, 10:16 a.m., Xiaohong Bao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/218/
> -----------------------------------------------------------
> 
> (Updated March 21, 2011, 10:16 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> partial fix for STORM-948: [crashhunters] meta-issue for bad_alloc exceptions
> fixed: crashed caused by snapshots, loading the last bitmap, too large texture memory due to insufficient physical memory
> also force to rebuild VBO if the memory is about to be running out to eliminate possible memory leaking caused by GPU driver.
> 
> the changeset: 30a545579ab6
> 
> 
> This addresses bug storm-948.
>     http://jira.secondlife.com/browse/storm-948
> 
> 
> Diffs
> -----
> 
>   indra/newview/llappviewer.h a8639217816b 
>   indra/newview/llappviewer.cpp a8639217816b 
>   indra/newview/llviewerdisplay.cpp a8639217816b 
>   indra/newview/llviewertexturelist.h a8639217816b 
>   indra/newview/llviewertexturelist.cpp a8639217816b 
>   indra/newview/llviewerwindow.cpp a8639217816b 
> 
> Diff: http://codereview.secondlife.com/r/218/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Xiaohong
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110326/1d756d11/attachment-0001.htm