[opensource-dev] Review Request: (STORM-380) There is a little delay in sound when gesture first time played

Boroondas Gupte sllists at boroon.dasgupta.ch
Tue Mar 29 14:17:03 PDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/231/#review518
-----------------------------------------------------------

Ship it!


Should be fine then, as far as I can tell.

- Boroondas


On March 28, 2011, 12:21 p.m., Seth ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/231/
> -----------------------------------------------------------
> 
> (Updated March 28, 2011, 12:21 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> First pass implementation of syncing the animations and sounds before the gesture starts playing.
> The actual playing of animations and sounds of a gesture starts only when all needed animations and sound files are loaded into viewer cache. This reduces the delay between animations and sounds meant to be played simultaneously but may increase the delay between the moment a gesture is triggered and the moment it starts playing.
> 
> 
> This addresses bug STORM-380.
>     http://jira.secondlife.com/browse/STORM-380
> 
> 
> Diffs
> -----
> 
>   indra/newview/llgesturemgr.h b3cfba00a29b 
>   indra/newview/llgesturemgr.cpp b3cfba00a29b 
> 
> Diff: http://codereview.secondlife.com/r/231/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Seth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110329/bf8f3ef5/attachment.htm 


More information about the opensource-dev mailing list