[opensource-dev] Review Request: (STORM-380) There is a little delay in sound when gesture first time played

Seth ProductEngine slitovchuk at productengine.com
Thu Mar 31 10:18:19 PDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/231/
-----------------------------------------------------------

(Updated March 31, 2011, 10:18 a.m.)


Review request for Viewer.


Changes
-------

- Fixed checking the pending downloads for each playing gesture separately.
- Fixed calling assets callback to clean up the void pointer in getAssetData() and avoid potential memory leaks.


Summary (updated)
-------

Added syncing animations and sounds before the gesture starts playing.
The actual playing of animations and sounds of a gesture starts only when all needed animations and sound files are loaded into viewer cache. This reduces the delay between animations and sounds meant to be played simultaneously but may increase the delay between the moment a gesture is triggered and the moment it starts playing.

Fixed calling assets callback to clean up the void pointer in getAssetData() and avoid potential memory leaks.


This addresses bug STORM-380.
    http://jira.secondlife.com/browse/STORM-380


Diffs (updated)
-----

  indra/llmessage/llassetstorage.cpp d30636c2a83a 
  indra/newview/llgesturemgr.h d30636c2a83a 
  indra/newview/llgesturemgr.cpp d30636c2a83a 

Diff: http://codereview.secondlife.com/r/231/diff


Testing
-------


Thanks,

Seth

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110331/518c8a17/attachment.htm 


More information about the opensource-dev mailing list