[opensource-dev] Review Request: CHOP-619 fix for pre-compiled headers issue
Brad Kittenbrink
brad at lindenlab.com
Wed May 4 15:36:25 PDT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/299/
-----------------------------------------------------------
Review request for Viewer.
Summary
-------
Fix for error using precompiled headers with vs2010 and incredibuild 3.60 beta2.
We'll use this opportunity to remove all the special cases we had for working around this problem.
resubmitted with the correct patch now...
This addresses bug CHOP-619.
http://jira.secondlife.com/browse/CHOP-619
Diffs
-----
autobuild.xml UNKNOWN
build.sh UNKNOWN
indra/cmake/00-Common.cmake UNKNOWN
indra/cmake/Variables.cmake UNKNOWN
Diff: http://codereview.secondlife.com/r/299/diff
Testing
-------
I tested builds personally on windows and linux although the cmake changes can only affect windows.
The changes are such that testing the viewer itself is completely unnecessary. If it builds, it's good.
Thanks,
Brad
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110504/77a229ed/attachment.htm
More information about the opensource-dev
mailing list