[opensource-dev] Review Request: Cleaning up testing cmake macros to prepare for refactoring them to improve build time.

Brad Kittenbrink brad at lindenlab.com
Mon May 9 18:29:39 PDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/301/
-----------------------------------------------------------

Review request for Viewer.


Summary
-------

Consolidating all references to the LL_TESTS config var in one file to make the logic surrounding it more cohesive.


This addresses bug CHOP-609.
    http://jira.secondlife.com/browse/CHOP-609


Diffs
-----

  indra/cmake/LLAddBuildTest.cmake UNKNOWN 
  indra/cmake/LLTestCommand.cmake UNKNOWN 
  indra/llcharacter/CMakeLists.txt UNKNOWN 
  indra/llcommon/CMakeLists.txt UNKNOWN 
  indra/llimage/CMakeLists.txt UNKNOWN 
  indra/llinventory/CMakeLists.txt UNKNOWN 
  indra/llkdu/CMakeLists.txt UNKNOWN 
  indra/llmath/CMakeLists.txt UNKNOWN 
  indra/llmessage/CMakeLists.txt UNKNOWN 
  indra/llplugin/CMakeLists.txt UNKNOWN 
  indra/llprimitive/CMakeLists.txt UNKNOWN 
  indra/llui/CMakeLists.txt UNKNOWN 
  indra/llvfs/CMakeLists.txt UNKNOWN 
  indra/llxml/CMakeLists.txt UNKNOWN 
  indra/newview/CMakeLists.txt UNKNOWN 
  indra/viewer_components/login/CMakeLists.txt UNKNOWN 
  indra/viewer_components/updater/CMakeLists.txt UNKNOWN 

Diff: http://codereview.secondlife.com/r/301/diff


Testing
-------

I've tested with LL_TESTS=ON, but I'd like some help from people who use this feature testing with LL_TESTS=OFF to make sure I haven't missed anything.


Thanks,

Brad

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110510/e3e1149f/attachment-0001.htm 


More information about the opensource-dev mailing list