[opensource-dev] Review Request: Cleaning up testing cmake macros to prepare for refactoring them to improve build time.

[Boroondas Gupte]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/301/#review688
-----------------------------------------------------------


Review Board can't apply your patch. Please upload a diff file that works. Some tips:
* Generate the diff file from hg rather than git, so that it contains revision IDs that RB knows about.
* If the change you want to review isn't based on a revision already in the repository you selected for this RB review request (lindenlab/viewer-development in this case), you must provide the diff between a known revision (i.e. one in lindenlab/viewer-development) and the base revision of your changeset as "Parent Diff".
* When creating a new review request or uploading a new diff file to an existing one, you can preview the diff (and see whether RB can apply it) before submitting the request/diff update by clicking the "View Diff" button.
** WARNING: Any changes to description, summary, tests done etc. that are being edited (i.e. have an "OK" and "Cancel" button visible) will be lost when you click "View Diff". To 'save' them (without submitting the request, yet), use the "OK" buttons associated with the respective input fields, and they will be kept while (p)reviewing your Diff.

- Boroondas


On May 9, 2011, 6:29 p.m., Brad Kittenbrink wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/301/
> -----------------------------------------------------------
> 
> (Updated May 9, 2011, 6:29 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Consolidating all references to the LL_TESTS config var in one file to make the logic surrounding it more cohesive.
> 
> 
> This addresses bug CHOP-609.
>     http://jira.secondlife.com/browse/CHOP-609
> 
> 
> Diffs
> -----
> 
>   indra/cmake/LLAddBuildTest.cmake UNKNOWN 
>   indra/cmake/LLTestCommand.cmake UNKNOWN 
>   indra/llcharacter/CMakeLists.txt UNKNOWN 
>   indra/llcommon/CMakeLists.txt UNKNOWN 
>   indra/llimage/CMakeLists.txt UNKNOWN 
>   indra/llinventory/CMakeLists.txt UNKNOWN 
>   indra/llkdu/CMakeLists.txt UNKNOWN 
>   indra/llmath/CMakeLists.txt UNKNOWN 
>   indra/llmessage/CMakeLists.txt UNKNOWN 
>   indra/llplugin/CMakeLists.txt UNKNOWN 
>   indra/llprimitive/CMakeLists.txt UNKNOWN 
>   indra/llui/CMakeLists.txt UNKNOWN 
>   indra/llvfs/CMakeLists.txt UNKNOWN 
>   indra/llxml/CMakeLists.txt UNKNOWN 
>   indra/newview/CMakeLists.txt UNKNOWN 
>   indra/viewer_components/login/CMakeLists.txt UNKNOWN 
>   indra/viewer_components/updater/CMakeLists.txt UNKNOWN 
> 
> Diff: http://codereview.secondlife.com/r/301/diff
> 
> 
> Testing
> -------
> 
> I've tested with LL_TESTS=ON, but I'd like some help from people who use this feature testing with LL_TESTS=OFF to make sure I haven't missed anything.
> 
> 
> Thanks,
> 
> Brad
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110510/a2eaa40d/attachment.htm