[opensource-dev] Review Request: STORM-1175 Fixing close button, for Custom Port warning, in Preferences > Setup > Network

[Vadim ProductEngine]

> On April 20, 2011, 9:01 a.m., Vadim ProductEngine wrote:
> > indra/llui/llnotifications.cpp, line 1536
> > <http://codereview.secondlife.com/r/271/diff/1/?file=1484#file1484line1536>
> >
> >     LLNotificationsUtil is a wrapper around LLNotifications. Calling a wrapper from the class it wraps doesn't look very nice to me.
> >     
> >     So I'd change this line to do the following:
> >     
> >         add(name.asString(), LLSD(), LLSD());
> >     
> >     and remove the include.
> >     
> >     Both approaches trigger a run-time warning though. I'll address that in a separate review request (coming soon).
> 
> Ima Mechanique wrote:
>     I've been waiting for the "separate review request" before continuing with this. Any idea when soon will be?

Sorry, it seems to require more time than I thought, and I've been busy with other work.
So no, I'm not going to fix the warning issue in the near future. That should not prevent you from submitting your fix though.


- Vadim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/271/#review637
-----------------------------------------------------------


On April 19, 2011, 7:57 a.m., Ima Mechanique wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/271/
> -----------------------------------------------------------
> 
> (Updated April 19, 2011, 7:57 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Applying Kitty Barnett's patch against current code base.
> 
> 
> This addresses bug STORM-1175.
>     http://jira.secondlife.com/browse/STORM-1175
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 584211e99147 
>   indra/llui/llnotifications.cpp 584211e99147 
> 
> Diff: http://codereview.secondlife.com/r/271/diff
> 
> 
> Testing
> -------
> 
> Release build. tested preferences both in world and on the log in screen.
> 
> 
> Thanks,
> 
> Ima
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110510/34dce096/attachment.htm