[opensource-dev] Review Request: STORM-951 Accidental Self-Muting/Self-Blocking

[Vadim ProductEngine]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/303/#review691
-----------------------------------------------------------



indra/newview/llnotificationofferhandler.cpp
<http://codereview.secondlife.com/r/303/#comment663>

    Are you sure this is the right place for such kind of check?
    
    I think it should rather be somewhere in llviewermessage.cpp (maybe process_improved_im()).



indra/newview/llviewermessage.cpp
<http://codereview.secondlife.com/r/303/#comment664>

    please add:
    * a reference to the ticket
    * a space after //



indra/newview/llviewermessage.cpp
<http://codereview.secondlife.com/r/303/#comment665>

    I'm not quite getting why there are two code paths for calling inventory_offer_mute_callback(), i.e. why not write it like this:
    
    ===
    LLUUID sender_id;
    
    if (mFromObject)
    {
    	const LLUUID& object_id = notification_ptr->getPayload()["object_id"].asUUID();
    	sender_id = object_id;
    }
    else
    {
    	sender_id = mFromID;
    }
    
    gCacheName->get(sender_id, mFromGroup, boost::bind(&inventory_offer_mute_callback,_1,_2,_3,notification_ptr->getResponderPtr()));
    ===
    
    And please move the comments to the lines where the corresponding conditions are.


- Vadim


On May 10, 2011, 3:45 a.m., Paul ProductEngine wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/303/
> -----------------------------------------------------------
> 
> (Updated May 10, 2011, 3:45 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> - To avoid self blocking, add blocked object by its ID. 
> 
> - Before showing offer from object, check whether this object is blocked, to avoid spamming offers from blocked objects.
> 
> 
> This addresses bug storm-951.
>     http://jira.secondlife.com/browse/storm-951
> 
> 
> Diffs
> -----
> 
>   indra/newview/llnotificationofferhandler.cpp 4a7158d7714c 
>   indra/newview/llviewermessage.cpp 4a7158d7714c 
> 
> Diff: http://codereview.secondlife.com/r/303/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20110510/391319d4/attachment-0001.htm