[opensource-dev] Review Request: As a music fan, I want audio to fade in gently so my immersion is increased

Oz Linden oz at lindenlab.com
Wed Nov 23 07:32:11 PST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/520/#review1088
-----------------------------------------------------------


A couple of minor suggestions, but generally very clear and clean code.

Kudos for good use of the singleton pattern.


indra/newview/llpanelnearbymedia.cpp
<http://codereview.secondlife.com/r/520/#comment1072>

    Please fix (and in the else below) to match the coding standard; add the braces.
    https://wiki.secondlife.com/wiki/Coding_Standard#Braces



indra/newview/llvieweraudio.cpp
<http://codereview.secondlife.com/r/520/#comment1074>

    I think this would be clearer if it were written as a switch statement without the early returns.



indra/newview/llvieweraudio.cpp
<http://codereview.secondlife.com/r/520/#comment1075>

    If you add an 'else' here, you can replace all the early returns in this method with assignments to a 'bool fadeIsFinished = false;' variable and return that at the bottom.


- Oz


On Nov. 23, 2011, 5:59 a.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/520/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2011, 5:59 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Audio fading in has been added for when a music stream starts.  Audio fading out has been added for when there is a change in the music stream that is playing.
> 
> Two dead files have been eliminated.
> 
> An existing bug in how music was not being paused correctly has been fixed.
> 
> When you are teleporting you will hear the music stream from the place you are leaving.  This is a change in behavior; previously the music stream was stopped when the teleport progress bar was being displayed.
> 
> This code change affects several areas where music is started or stopped.  The new code has evolved significantly, so please look for things that might not "make sense."
> 
> 
> This addresses bug STORM-591.
>     http://jira.secondlife.com/browse/STORM-591
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 8b455c1b7a5e 
>   indra/newview/lloverlaybar.h 8b455c1b7a5e 
>   indra/newview/lloverlaybar.cpp 8b455c1b7a5e 
>   indra/newview/llpanelnearbymedia.h 8b455c1b7a5e 
>   indra/newview/llpanelnearbymedia.cpp 8b455c1b7a5e 
>   indra/newview/llvieweraudio.h 8b455c1b7a5e 
>   indra/newview/llvieweraudio.cpp 8b455c1b7a5e 
>   indra/newview/llviewermedia.cpp 8b455c1b7a5e 
>   indra/newview/llviewerparcelmgr.cpp 8b455c1b7a5e 
> 
> Diff: http://codereview.secondlife.com/r/520/diff
> 
> 
> Testing
> -------
> 
> See the massive test plan in the jira.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20111123/24310fde/attachment-0001.htm 


More information about the opensource-dev mailing list