[opensource-dev] Review Request: STORM-1899: Avatar hand poses randomly get stuck in spread position

[Richard Nelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/592/#review1238
-----------------------------------------------------------



indra/llcharacter/llhandmotion.cpp
<http://codereview.secondlife.com/r/592/#comment1136>

    you probably don't want to write to this memory if you are getting bad values.  Best to warn and then do nothing.


- Richard Nelson


On July 19, 2012, 2:11 p.m., Ansariel Hiller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/592/
> -----------------------------------------------------------
> 
> (Updated July 19, 2012, 2:11 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> -------
> 
> A proposed solution for STORM-1899 and the issue, where the handpose of avatars randomly get stuck in the spread hand position.
> 
> In the current implementation, this case might happen under the following circumstances:
> * Avatar uses an animation with hand pose A
> * A request is issued to change hand pose to B
> * Before the viewer has blended pose A over to pose B, the original pose A is requested again
> * In this case, the hand pose will not be properly (re)set and because mNewPose == mCurrentPose, there will be no further blending, leaving the hand in it's current pose
> 
> The patch will properly reset the hand pose in this case and update the visual parameters of the avatar.
> 
> 
> This addresses bug STORM-1899.
>     https://jira.secondlife.com/browse/STORM-1899
> 
> 
> Diffs
> -----
> 
>   indra/llcharacter/llhandmotion.cpp 4d9106153407 
> 
> Diff: http://codereview.secondlife.com/r/592/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ansariel Hiller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20120719/e6fe43e0/attachment.htm