[opensource-dev] Review Request: Don't save per-account settings if login not fully successful
Oz Linden
oz at lindenlab.com
Tue May 1 10:06:11 PDT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/578/#review1217
-----------------------------------------------------------
Ship it!
Ship It!
- Oz Linden
On May 1, 2012, 9:26 a.m., Jonathan Yap wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/578/
> -----------------------------------------------------------
>
> (Updated May 1, 2012, 9:26 a.m.)
>
>
> Review request for Viewer.
>
>
> Description
> -------
>
> The viewer resets your "per-account" settings when you try to log in too fast after a crash ("the region is logging you out") and then quit the viewer before a successful login.
>
> See comment and link to fix in https://jira.secondlife.com/browse/STORM-1794?focusedCommentId=305543&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-305543
>
> Repo:
> Somehow crash your viewer
>
> Try to log back in immediately: You get a message "The region is logging you out"
>
> Quit the viewer at this point: your per-account settings are now zorched, as they were not yet read in, but are being written out.
>
>
> This addresses bug STORM-1842.
>
>
> Diffs
> -----
>
> doc/contributions.txt 0a41a8750048
> indra/newview/llappviewer.h 0a41a8750048
> indra/newview/llappviewer.cpp 0a41a8750048
>
> Diff: http://codereview.secondlife.com/r/578/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jonathan Yap
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20120501/4a364866/attachment.htm
More information about the opensource-dev
mailing list