[opensource-dev] Review Request: Don't save per-account settings if login not fully successful

Brian McGroarty soft at lindenlab.com
Tue May 1 10:13:25 PDT 2012


Beautiful. This looks like it would also cover the window sizes and
positions getting reset every time login is aborted for a forced upgrade.

https://jira.secondlife.com/browse/VWR-28385


On Tue, May 1, 2012 at 9:26 AM, Jonathan Yap <jhwelch at gmail.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/578/
>   Review request for Viewer.
> By Jonathan Yap.
>
> *Updated May 1, 2012, 9:26 a.m.*
> Description
>
> The viewer resets your "per-account" settings when you try to log in too fast after a crash ("the region is logging you out") and then quit the viewer before a successful login.
>
> See comment and link to fix in https://jira.secondlife.com/browse/STORM-1794?focusedCommentId=305543&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-305543
>
> Repo:
> Somehow crash your viewer
>
> Try to log back in immediately: You get a message "The region is logging you out"
>
> Quit the viewer at this point: your per-account settings are now zorched, as they were not yet read in, but are being written out.
>
>   *Bugs: * STORM-1842
> Diffs
>
>    - doc/contributions.txt (0a41a8750048)
>    - indra/newview/llappviewer.h (0a41a8750048)
>    - indra/newview/llappviewer.cpp (0a41a8750048)
>
> View Diff <http://codereview.secondlife.com/r/578/diff/>
>
> _______________________________________________
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/OpenSource-Dev
> Please read the policies before posting to keep unmoderated posting
> privileges
>



-- 
Brian McGroarty | Linden Lab
Sent from my Newton MP2100 via acoustic coupler
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20120501/59b153dc/attachment.htm 


More information about the opensource-dev mailing list