[opensource-dev] Review Request: BUG-59: Go-to line function for the internal LSL script editor

Kelly Washington kelly at lindenlab.com
Fri Sep 14 13:08:12 PDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/596/#review1262
-----------------------------------------------------------



indra/newview/llpreviewscript.cpp
<http://codereview.secondlife.com/r/596/#comment1151>

    Please put new classes in a new file. (Don't mimic my bad code from years ago, please. :) )



indra/newview/llpreviewscript.cpp
<http://codereview.secondlife.com/r/596/#comment1152>

    Need null checks on mEditorCore and mEditor



indra/newview/llpreviewscript.cpp
<http://codereview.secondlife.com/r/596/#comment1153>

    Need null checks on mEditorCore, mEditor and sInstance



indra/newview/llpreviewscript.cpp
<http://codereview.secondlife.com/r/596/#comment1154>

    minor note: This comment is backwards from the code - you describe the unwritten else case instead of the implemented if case. It confused me at first. Something like '// only deselect, setfocus and close if the cursor actually moved' would match the code written, or moving the comment to after the if block with something like '// else do nothing <etc>'



indra/newview/llpreviewscript.cpp
<http://codereview.secondlife.com/r/596/#comment1155>

    Need null pointer checks on mEditorCore and mEditor.


- Kelly Washington


On Sept. 13, 2012, 8:38 a.m., MartinRJ Fayray wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/596/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2012, 8:38 a.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Description
> -------
> 
> Repository is here: https://bitbucket.org/MartinRJ/bug-59
> 
> I more or less cloned the search-function and modified the floater via xml (new file: floater_goto_line.xml) to fit for a 'go to line' floater.
> Also I added a callback to prevalidate the input in the 'go to line' line-editor, so that only numbers can be entered into it.
> 
> 
> This addresses bug BUG-59.
>     https://jira.secondlife.com/browse/BUG-59
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 7a056d7afeb2 
>   indra/newview/llpreviewscript.h 7a056d7afeb2 
>   indra/newview/llpreviewscript.cpp 7a056d7afeb2 
>   indra/newview/skins/default/xui/en/floater_goto_line.xml PRE-CREATION 
>   indra/newview/skins/default/xui/en/panel_script_ed.xml 7a056d7afeb2 
> 
> Diff: http://codereview.secondlife.com/r/596/diff/
> 
> 
> Testing
> -------
> 
> Tested on my local PC with a modded "3.3.4-release3" version.
> Open a script with at least 300 lines inside inventory, go to menu 'Edit-> go to line', enter a number less than 300 into the 'Go to' - field. Expected result: the cursor jumps to the entered line number (column 0).
> Repeat the test with a script inside an object's content.
> 
> 
> Thanks,
> 
> MartinRJ Fayray
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20120914/0bce08ca/attachment.htm 


More information about the opensource-dev mailing list