[opensource-dev] Review Request: BUG-59: Go-to line function for the internal LSL script editor

MartinRJ Fayray fuerholz at gmx.net
Tue Sep 18 16:11:33 PDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/596/
-----------------------------------------------------------

(Updated Sept. 18, 2012, 4:11 p.m.)


Review request for Viewer.


Changes
-------

I moved LLFloaterGotoLine into a new class file (llfloatergotoline.cpp with the header file llfloatergotoline.h), according to Kelly's review (and updated CMakeLists.txt),
added some null-checks in LLFloaterGotoLine and LLFloaterScriptSearch,
and I set "setCommitOnFocusLost" to FALSE (for the lineeditor in LLFloaterGotoLine::postBuild / LLFloaterScriptSearch::postBuild), to prevent unexpected commits/search.


Description
-------

Repository is here: https://bitbucket.org/MartinRJ/bug-59

I more or less cloned the search-function and modified the floater via xml (new file: floater_goto_line.xml) to fit for a 'go to line' floater.
Also I added a callback to prevalidate the input in the 'go to line' line-editor, so that only numbers can be entered into it.


This addresses bug BUG-59.
    https://jira.secondlife.com/browse/BUG-59


Diffs (updated)
-----

  doc/contributions.txt 7a056d7afeb2 
  indra/newview/CMakeLists.txt 7a056d7afeb2 
  indra/newview/llfloatergotoline.h PRE-CREATION 
  indra/newview/llfloatergotoline.cpp PRE-CREATION 
  indra/newview/llpreviewscript.h 7a056d7afeb2 
  indra/newview/llpreviewscript.cpp 7a056d7afeb2 
  indra/newview/skins/default/xui/en/floater_goto_line.xml PRE-CREATION 
  indra/newview/skins/default/xui/en/panel_script_ed.xml 7a056d7afeb2 

Diff: http://codereview.secondlife.com/r/596/diff/


Testing
-------

Tested on my local PC with a modded "3.3.4-release3" version.
Open a script with at least 300 lines inside inventory, go to menu 'Edit-> go to line', enter a number less than 300 into the 'Go to' - field. Expected result: the cursor jumps to the entered line number (column 0).
Repeat the test with a script inside an object's content.


Thanks,

MartinRJ Fayray

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20120918/eac837dd/attachment.htm 


More information about the opensource-dev mailing list