[opensource-dev] Review Request: OPEN-172 Combined changesets for Linux gcc 4.7, 2 build of viewer development

Nicky Perian nickyperian at yahoo.com
Fri Apr 12 10:27:49 PDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/618/
-----------------------------------------------------------

(Updated April 12, 2013, 10:27 a.m.)


Review request for Viewer.


Changes
-------

Added virtual destructor, returned llviewertexture.cpp to original.


Description
-------

OPEN-172 Combined changesets for Linux gcc 4.7,2 build of viewer development  


This addresses bug OPEN-172.
    http://jira.secondlife.com/browse/OPEN-172


Diffs (updated)
-----

  indra/cmake/00-Common.cmake fc8c50bc74f5 
  indra/cmake/Copy3rdPartyLibs.cmake fc8c50bc74f5 
  indra/cmake/LLAddBuildTest.cmake fc8c50bc74f5 
  indra/linux_updater/linux_updater.cpp fc8c50bc74f5 
  indra/llappearance/lltexturemanagerbridge.h fc8c50bc74f5 
  indra/llappearance/llwearabletype.h fc8c50bc74f5 
  indra/llcommon/lldarray.h fc8c50bc74f5 
  indra/llcommon/lleventcoro.h fc8c50bc74f5 
  indra/llcommon/llinitparam.h fc8c50bc74f5 
  indra/llcommon/llrefcount.h fc8c50bc74f5 
  indra/llcorehttp/CMakeLists.txt fc8c50bc74f5 
  indra/llmath/lloctree.h fc8c50bc74f5 
  indra/llmessage/CMakeLists.txt fc8c50bc74f5 
  indra/llmessage/lliopipe.h fc8c50bc74f5 
  indra/llmessage/llregionpresenceverifier.cpp fc8c50bc74f5 
  indra/llui/llview.cpp fc8c50bc74f5 
  indra/media_plugins/gstreamer010/media_plugin_gstreamer010.cpp fc8c50bc74f5 
  indra/newview/llcommunicationchannel.cpp fc8c50bc74f5 
  indra/newview/llfloaterpathfindingobjects.cpp fc8c50bc74f5 
  indra/newview/llsurfacepatch.cpp fc8c50bc74f5 
  indra/newview/llworld.cpp fc8c50bc74f5 
  indra/test/CMakeLists.txt fc8c50bc74f5 
  indra/test/test.cpp fc8c50bc74f5 

Diff: http://codereview.secondlife.com/r/618/diff/


Testing (updated)
-------

Built on debian wheezy virtual box virtual machine. Logged on secondlife. Checked logs and found no spamming. Do not have a native machine to test with.
The change to llviewertexture.cpp around line 419 needs a close look.


Thanks,

Nicky Perian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20130412/5898c3ec/attachment-0001.htm 


More information about the opensource-dev mailing list