[opensource-dev] Review Request: OPEN-172 Combined changesets for Linux gcc 4.7, 2 build of viewer development

Nicky Perian nickyperian at yahoo.com
Sat Apr 13 15:21:24 PDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/618/
-----------------------------------------------------------

(Updated April 13, 2013, 3:21 p.m.)


Review request for Viewer.


Changes
-------

Added conditional around new std=c++11 code that would cause build problem on Darwin and Windows and Linux without std=c++11.


Description
-------

OPEN-172 Combined changesets for Linux gcc 4.7,2 build of viewer development  


This addresses bug OPEN-172.
    http://jira.secondlife.com/browse/OPEN-172


Diffs (updated)
-----

  indra/cmake/00-Common.cmake c085df84186a 
  indra/cmake/Copy3rdPartyLibs.cmake c085df84186a 
  indra/cmake/LLAddBuildTest.cmake c085df84186a 
  indra/linux_updater/linux_updater.cpp c085df84186a 
  indra/llappearance/lltexturemanagerbridge.h c085df84186a 
  indra/llappearance/llwearabletype.h c085df84186a 
  indra/llcommon/lldarray.h c085df84186a 
  indra/llcommon/lleventcoro.h c085df84186a 
  indra/llcommon/llinitparam.h c085df84186a 
  indra/llcommon/llrefcount.h c085df84186a 
  indra/llcorehttp/CMakeLists.txt c085df84186a 
  indra/llmath/lloctree.h c085df84186a 
  indra/llmessage/CMakeLists.txt c085df84186a 
  indra/llmessage/lliopipe.h c085df84186a 
  indra/llmessage/llregionpresenceverifier.cpp c085df84186a 
  indra/llui/llview.cpp c085df84186a 
  indra/media_plugins/gstreamer010/media_plugin_gstreamer010.cpp c085df84186a 
  indra/newview/llcommunicationchannel.cpp c085df84186a 
  indra/newview/llfloaterpathfindingobjects.cpp c085df84186a 
  indra/newview/llsurfacepatch.cpp c085df84186a 
  indra/newview/llworld.cpp c085df84186a 
  indra/test/CMakeLists.txt c085df84186a 
  indra/test/test.cpp c085df84186a 

Diff: http://codereview.secondlife.com/r/618/diff/


Testing
-------

Built on debian wheezy virtual box virtual machine. Logged on secondlife. Checked logs and found no spamming. Do not have a native machine to test with.
The change to llviewertexture.cpp around line 419 needs a close look.


Thanks,

Nicky Perian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20130413/d353e688/attachment.htm 


More information about the opensource-dev mailing list