[opensource-dev] Review Request: VWR-29083 Make SSAO work better

Tofu Buzzard c at yotes.com
Fri Jan 11 13:16:43 PST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/612/
-----------------------------------------------------------

(Updated Jan. 11, 2013, 1:16 p.m.)


Review request for Viewer.


Changes
-------

Updated patch with a bunch more comments, made settings reflect what I've actually been testing with, reconciled class1 and class2 better, and added a new quality improvement (disregard samples which are being taken from outside the screen extents - eliminates spurious SSAO fringe at screen edges at some angles).


Description
-------

Use a different scheme for weighting SSAO samples, apply SSAO before fog is applied, fix a bug in the screen-space shadow/ssao smoothing offset where the 'checkerboard' stipple had been refactored incorrectly, change some default settings in line with the resulting visual changes.  Also, improve comments a bit. :3


This addresses bug VWR-29083.
    http://jira.secondlife.com/browse/VWR-29083


Diffs (updated)
-----

  doc/contributions.txt UNKNOWN 
  indra/llrender/llshadermgr.h UNKNOWN 
  indra/llrender/llshadermgr.cpp UNKNOWN 
  indra/newview/app_settings/settings.xml UNKNOWN 
  indra/newview/app_settings/shaders/class1/deferred/blurLightF.glsl UNKNOWN 
  indra/newview/app_settings/shaders/class1/deferred/softenLightF.glsl UNKNOWN 
  indra/newview/app_settings/shaders/class1/deferred/sunLightSSAOF.glsl UNKNOWN 
  indra/newview/app_settings/shaders/class2/deferred/softenLightF.glsl UNKNOWN 
  indra/newview/app_settings/shaders/class2/deferred/sunLightSSAOF.glsl UNKNOWN 
  indra/newview/pipeline.cpp UNKNOWN 

Diff: http://codereview.secondlife.com/r/612/diff/


Testing
-------

Been running with this for months on an assortment of nvidia hardware, linux only.


Thanks,

Tofu Buzzard

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20130111/905a7e23/attachment.htm 


More information about the opensource-dev mailing list