[opensource-dev] Review Request: VWR-29083 Make SSAO work better

Tofu Buzzard c at yotes.com
Fri Jan 11 13:22:24 PST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/612/
-----------------------------------------------------------

(Updated Jan. 11, 2013, 1:22 p.m.)


Review request for Viewer.


Description (updated)
-------

Use a different scheme for weighting SSAO samples, apply SSAO before fog is applied, fix a bug in the screen-space shadow/ssao smoothing offset where the 'checkerboard' stipple had been refactored incorrectly, change some default settings in line with the resulting visual changes.  Disregard samples which are being taken from outside the screen extents - eliminates spurious SSAO fringe at screen edges at some angles.  Micro-optimize the shadow co-ord calculation.  Also, improve comments a bit. :3


This addresses bug VWR-29083.
    http://jira.secondlife.com/browse/VWR-29083


Diffs
-----

  doc/contributions.txt UNKNOWN 
  indra/llrender/llshadermgr.h UNKNOWN 
  indra/llrender/llshadermgr.cpp UNKNOWN 
  indra/newview/app_settings/settings.xml UNKNOWN 
  indra/newview/app_settings/shaders/class1/deferred/blurLightF.glsl UNKNOWN 
  indra/newview/app_settings/shaders/class1/deferred/softenLightF.glsl UNKNOWN 
  indra/newview/app_settings/shaders/class1/deferred/sunLightSSAOF.glsl UNKNOWN 
  indra/newview/app_settings/shaders/class2/deferred/softenLightF.glsl UNKNOWN 
  indra/newview/app_settings/shaders/class2/deferred/sunLightSSAOF.glsl UNKNOWN 
  indra/newview/pipeline.cpp UNKNOWN 

Diff: http://codereview.secondlife.com/r/612/diff/


Testing
-------

Been running with this for months on an assortment of nvidia hardware, linux only.


Thanks,

Tofu Buzzard

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/opensource-dev/attachments/20130111/fd9c95da/attachment.htm 


More information about the opensource-dev mailing list