[sldev] comments on patch for VWR-423

[Alissa Sabre]

> I've attached a patch to VWR-423 to cover both VWR-423 and VWR-1187.

Thank you for the effort!

> would like some more eyes on
> it since this is my first patch.

I glanced at the patch and noticed that you forgot another change.  I
added a comment on JIRA.

# I've just glanced; not tested...

Other comments:

- Please be more specific on the source version that your patch is
  against.  Indicate "1.18.0.6" instead of "1.18" in this case.

- Use of full path names with DOS drive letter for the patched files
  confused my tools...  It is appreciated if you use relative paths
  without drive letters next time.

- You made some white-space-only change on the source.  It makes the
  patch redundant.  Please revert those changes before submission, or
  enable "ignore white-space-only changes" on your diff tool.

Hope this helps,

    Alissa Sabre
--------------------------------------
Easy + Joy + Powerful = Yahoo! Bookmarks x Toolbar
http://pr.mail.yahoo.co.jp/toolbar/