[sldev] comments on patch for VWR-423

[ham]

Thanks for the responses Nick and Alissa.

>Use of full path names with DOS drive letter for the patched files
>confused my tools...  It is appreciated if you use relative paths
> without drive letters next time.

I'm using the cygwin tool on my c: drive and the code is on my d: drive and 
unfortunately i've only used ClearCase and StarTeam which does the merging 
for you and you just confirm visually if there is a question. I'm new at 
using this kind of tool for diffs so I apologize. I didn't realize that 
where my code is stored made a difference to others downstream when applying 
the patch so if anyone would be kind enough to respond either on list or off 
doesn't matter to me and help me make this change I would be extremely 
grateful :)

I will clean up the whitespace issue and don't need help with that.
I have a couple of other changes based on Nicks's feedback so I'll post a 
new patch. I've put a note on jira as well.

----- Original Message ----- 
From: Alissa Sabre
To: sldev at lists.secondlife.com
Sent: Tuesday, July 24, 2007 9:32 AM
Subject: Re: [sldev] comments on patch for VWR-423


> I've attached a patch to VWR-423 to cover both VWR-423 and VWR-1187.

Thank you for the effort!

> would like some more eyes on
> it since this is my first patch.

I glanced at the patch and noticed that you forgot another change.  I
added a comment on JIRA.

# I've just glanced; not tested...

Other comments:

- Please be more specific on the source version that your patch is
  against.  Indicate "1.18.0.6" instead of "1.18" in this case.

- Use of full path names with DOS drive letter for the patched files
  confused my tools...  It is appreciated if you use relative paths
  without drive letters next time.

- You made some white-space-only change on the source.  It makes the
  patch redundant.  Please revert those changes before submission, or
  enable "ignore white-space-only changes" on your diff tool.

Hope this helps,

    Alissa Sabre
--------------------------------------
Easy + Joy + Powerful = Yahoo! Bookmarks x Toolbar
http://pr.mail.yahoo.co.jp/toolbar/

_______________________________________________
Click here to unsubscribe or manage your list subscription:
/index.html