[sldev] Texture caching
Dzonatas
dzonatas at dzonux.net
Tue Mar 20 11:37:12 PDT 2007
Jason Giglio wrote:
> Attached is the code cleanup patch, I haven't submitted it to LL
> because I plan on making a lot more changes eventually.
This is minor. Don't need braces for simple code-flow. In you patch you
have:
if(mReadOnly)
{
return;
}
Could be changed to:
if(mReadOnly)
return;
Also, in your patch:
- if (num_entries * (S32)sizeof(Entry) != filesize)
+
+ //make sure the file is a multiple of the Entry size
+ if( filesize % (S32)sizeof(Entry) != 0)
No need for your comment, as I can read the code just fine. However, I
prefer the way you used the "%".
=)
More information about the SLDev
mailing list