[sldev] Re: dead code

[Andrew Meadows]

Ben Byer -

Your list undoubtedly contains lots of dead code however I
find some of it suspiciously alive.  Consider the the LLAgent
methods.  The LLAgent constructor is in the list, however the
SL viewer has a big fat global LLAgent called gAgent that is
initialized in viewer.cpp using, as far as I can tell, the only
constructor that is defined in the LLAgent class.

If you track down some of the other LLAgent methods listed here
it appears a few are actually being called.  For instance,
LLAgent::getCameraMinOffGround() is called inside of
LLAgent::calcCameraPositionTargetGlobal() which is not on your
list.

Some other examples of non-LLAgent undead code:

~LLMatrix4()   sure it's a trivial method and not explicitly called, but it shouldn't be removed
LLPipeline::unloadShaders()   explicitly called in LLPipeline::destroyGL()
LLPrimitive()  explicitly called in constructor of LLViewerObject, which derives from LLPrimitive

- Andrew

...
LLAgent::LLAgent()
LLAgent::addWearableToAgentInventoryCallback::addWearableToAgentInventoryCallback(LLPointer<LLRefCount>, int, LLWearable*, unsigned int)
LLAgent::buildFullnameAndTitle(std::basic_string<char, std::char_traits<char>, std::allocator<char> >&) const
LLAgent::clearControlFlags(unsigned int)
LLAgent::clearRenderState(unsigned char)
LLAgent::copyWearableToInventory(EWearableType)
LLAgent::createStandardWearablesAllDone()
LLAgent::createStandardWearablesAllDoneCallback::~createStandardWearablesAllDoneCallback()
LLAgent::createStandardWearablesDone(int)
LLAgent::getCameraMinOffGround()
LLAgent::getLookAtType()
LLAgent::getName(LLStringBase<char>&)
LLAgent::getName(LLStringBase<char>&)::__FUNCTION__
LLAgent::getName(LLStringBase<char>&)::_site
LLAgent::getPointAtType()
LLAgent::getPowerInGroup(LLUUID const&) const
LLAgent::getQuat() const
LLAgent::getWearablePermMask(EWearableType)
LLAgent::needsReplacement(EWearableType, int)
LLAgent::recoverMissingWearableDone()
LLAgent::renderAutoPilotTarget()
LLAgent::resetAxes()
LLAgent::roll(float)
LLAgent::rotate(LLMatrix3 const&)
LLAgent::rotate(LLQuaternion const&)
LLAgent::rotate(float, LLVector3 const&)
LLAgent::sendAgentWearablesUpdateCallback::~sendAgentWearablesUpdateCallback()
LLAgent::setEffectColor(LLColor4 const&)
LLAgent::setKey(int, int&)
LLAgent::setRenderState(unsigned char)
LLAgent::startFollowPilot(LLUUID const&)
LLAgent::~LLAgent()
...