[sldev] Re: [VIEWER] 64 bit status and open source components (David Fries)

Argent Stonecutter secret.argent at gmail.com
Fri Sep 14 07:19:12 PDT 2007


From: David Fries <david at fries.net>
> ignore all the build steps about copying (shudder) system include/ 
> library files to the source tree and apply the included patch.   
> That lets it reference the system include files the way the are  
> supposed to be included.

If this is generally usable for more than just amd64, I hope the  
Lindens pick it up as well, because that always bugged me. Have you  
filed it as a patch in JIRA?

Also, while I was reading through your patches, I noticed this:

> --- indra/newview/llviewerparcelmgr.cpp	18 Jul 2007 00:32:05 -0000	 
> 1.12
> +++ indra/newview/llviewerparcelmgr.cpp	18 Jul 2007 00:33:07 -0000	 
> 1.5.2.6
> @@ -181,7 +181,7 @@ LLViewerParcelMgr::~LLViewerParcelMgr()
>  	mCollisionSegments = NULL;
>
>  	// weird, this crashes if I use an array delete on it!
> -	delete sPackedOverlay;
> +	delete[] sPackedOverlay;
>  	sPackedOverlay = NULL;
>
>  	delete[] mAgentParcelOverlay;
>

If you fixed whatever was breaking the array delete, you probably  
ought to remove the comment. :)

I don't grok C++ enough to know if you've just masked an underlying  
problem or fixed it, but I figure it'd be interesting and educational  
if you can elaborate on this particular patch. :)



More information about the SLDev mailing list