[sldev] Re: -Werror problem in trunk

Soft soft at lindenlab.com
Thu Aug 21 09:38:28 PDT 2008


On Thu, Aug 21, 2008 at 10:37 AM, Jason Giglio <gigstaggart at gmail.com> wrote:
> Soft wrote:
>>> look at the definition of the struct at llrender.h 221;
>>>
>>> the name of the struct is not in the "correct" place :-
>>>
>>>  typedef struct Vertex
>>>                {
>>>                        GLfloat v[3];
>>>                        GLubyte c[4];
>>>                        GLfloat uv[2];
>>>                };
>>>
>>> should be :-
>>>
>>> typedef struct
>>>        {
>>>                        GLfloat v[3];
>>>                        GLubyte c[4];
>>>                        GLfloat uv[2];
>>>         } Vertex;
>>>
>>>
>>> gcc 4.3 is a lot more fussy about syntax. That should fix it.
>
> Is this actually the right way to go?  Isn't the preferred syntax to
> actually just say "struct Vertex { ... };".

As per the comments - either will work, but Gigs is right. This would
be more orthogonal to the rest of our code, so I'll flip it over to
this style.


More information about the SLDev mailing list