[sldev] [VWR[[PATCH] LLTextureCache::writeToCache() does notcache textures smaller than TEXTURE_CACHE_ENTRY_SIZE

[Carlo Wood]

I'm not so sure this is a bug...

Isn't the cache using a limit on the number of textures it saves?
Or is it purely the total size of all textures together?

If it's the first, then it would make sense to not store small
textures in order to make room for larger ones. That being said,
if that is the intention then it's the most broken "algorithm"
I've ever seen, lol.

On Fri, Apr 03, 2009 at 05:19:13PM -0700, Rob Lanphier wrote:
> Hi Robin,
> 
> Any chance you (or someone) could make a unit test that tickles this
> bug? I suspect that'd really help out with the analysis.
> 
> Rob
> 
> On 04/03/2009 01:37 PM, Philippe Bossut (Merov Linden) wrote:
> > Hi Robin,
> >
> > Thanks for filing a JIRA and for the patch. I'll test and review  
> > within 48 hours.
> >
> > Cheers,
> > - Merov
> >
> > On Apr 3, 2009, at 7:00 AM, Robin Cornelius wrote:
> >
> >   
> >> As discussed at Rob's hour yesterday, i've detected an issue with the
> >> texture caching that is preventing saving very small textures in to
> >> the cache.
> >>
> >> I've opened a JIRA and attached a patch to
> >> http://jira.secondlife.com/browse/VWR-12686.
> >>
> >> I'm well aware that the first 600 bytes are stored in an index file.
> >> but the code path i have identified will not make any attempt to save
> >> any data if the data is smaller than TEXTURE_CACHE_ENTRY_SIZE. It will
> >> just delete the WriteResponder and return. After the llTextureFetch
> >> has finished running and decoded it moves to state cache. this invokes
> >> LLtextureCache::WriteToCache() which is the only path of saving to the
> >> disk cache.
> >>
> >> I would quite like to commit this to http-texture as it seems very
> >> relevant to that branch currently as textures are the focus. So Merov,
> >> i think this is your area currently?
> >>
> >> Regards
> >>
> >> Robin
> >>     
> >
> > _______________________________________________
> > Policies and (un)subscribe information available here:
> > http://wiki.secondlife.com/wiki/SLDev
> > Please read the policies before posting to keep unmoderated posting privileges
> >   
> 
> _______________________________________________
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/SLDev
> Please read the policies before posting to keep unmoderated posting privileges

-- 
Carlo Wood <carlo at alinoe.com>