[sldev] [VWR[[PATCH] LLTextureCache::writeToCache() does notcache textures smaller than TEXTURE_CACHE_ENTRY_SIZE

[Philippe Bossut (Merov Linden)]

Hi Robin,

I reviewed the patch and commented in the JIRA. The skinny: I think  
you're right, there's definitely something fishy there as the  
doWrite() on the worker does take care of writing the header. There is  
actually another piece of code in the doWrite() that is also weird as  
I mentioned in the JIRA. Looking at it, that's a classic case of  
unclear separation of concerns between a collection of objects. (/me  
chanting "unit test! unit test!")

In any case, I'll check Monday first thing on my office's machine  
(better dev environment than I have at home...) and we'll get to the  
bottom of this.

Thanks for the hawk eye! :)

Cheers,
- Merov

On Apr 3, 2009, at 1:37 PM, Philippe Bossut (Merov Linden) wrote:

> Hi Robin,
>
> Thanks for filing a JIRA and for the patch. I'll test and review
> within 48 hours.
>
> Cheers,
> - Merov
>
> On Apr 3, 2009, at 7:00 AM, Robin Cornelius wrote:
>
>> As discussed at Rob's hour yesterday, i've detected an issue with the
>> texture caching that is preventing saving very small textures in to
>> the cache.
>>
>> I've opened a JIRA and attached a patch to
>> http://jira.secondlife.com/browse/VWR-12686.
>>
>> I'm well aware that the first 600 bytes are stored in an index file.
>> but the code path i have identified will not make any attempt to save
>> any data if the data is smaller than TEXTURE_CACHE_ENTRY_SIZE. It  
>> will
>> just delete the WriteResponder and return. After the llTextureFetch
>> has finished running and decoded it moves to state cache. this  
>> invokes
>> LLtextureCache::WriteToCache() which is the only path of saving to  
>> the
>> disk cache.
>>
>> I would quite like to commit this to http-texture as it seems very
>> relevant to that branch currently as textures are the focus. So  
>> Merov,
>> i think this is your area currently?
>>
>> Regards
>>
>> Robin
>
> _______________________________________________
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/SLDev
> Please read the policies before posting to keep unmoderated posting  
> privileges