[sldev] [VWR[[PATCH] LLTextureCache::writeToCache() does notcache textures smaller than TEXTURE_CACHE_ENTRY_SIZE

[Philippe Bossut (Merov Linden)]

Hi Robin,

On Apr 5, 2009, at 11:39 AM, Robin Cornelius wrote:
> As for the unit tests, they don't appear to be in a great shape for
> outside of LL builds currently. Although you have a couple working the
> majority in test are not even included in the (exported) CMake rules  
> and
> they seem to require quite a bit of TLC to build, I've given up for  
> the
> moment. But will have to play a lot more.

I wasn't blaming you a second for the lack of unit test! That chant  
for mostly for me and my fellow Lindens. This is something we are  
trying to get right now but it takes a lot of effort and sometimes we  
wonder if those would ever catch anything serious. In that case, I do  
think though that this particular bug would have been caught by unit  
tests on lltexturecache.cpp if we had written any (in that case, cache  
a small texture, verify that you can access it using its UUID, this  
would have failed right there).

But you're right, I should write this one as an example rather than  
ranting about it :)

Cheers,
- Merov