[sldev] [VWR[[PATCH] LLTextureCache::writeToCache() does notcache textures smaller than TEXTURE_CACHE_ENTRY_SIZE

Robin Cornelius robin.cornelius at gmail.com
Sun Apr 5 11:39:50 PDT 2009


Philippe Bossut (Merov Linden) wrote:
> Hi Robin,
> 
> I reviewed the patch and commented in the JIRA. The skinny: I think  
> you're right, there's definitely something fishy there as the  
> doWrite() on the worker does take care of writing the header. There is  
> actually another piece of code in the doWrite() that is also weird as  
> I mentioned in the JIRA. Looking at it, that's a classic case of  
> unclear separation of concerns between a collection of objects. (/me  
> chanting "unit test! unit test!")

As i mentioed on the JIRA comment, i did most testing on 1.22.11 which
does not have the 2nd code that you found, so thats an additional
problem that has very recently been introduced.


As for the unit tests, they don't appear to be in a great shape for
outside of LL builds currently. Although you have a couple working the
majority in test are not even included in the (exported) CMake rules and
 they seem to require quite a bit of TLC to build, I've given up for the
moment. But will have to play a lot more.

> 
> In any case, I'll check Monday first thing on my office's machine  
> (better dev environment than I have at home...) and we'll get to the  
> bottom of this.

Thanks

Robin


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
Url : http://lists.secondlife.com/pipermail/sldev/attachments/20090405/9eb7f0e0/attachment.pgp 


More information about the SLDev mailing list