[sldev] Request For Comments on the patch in VWR-10579

[Ricky]

I copied the contents of the *OpenJPEG.cmake files to create what I did
there.  I do not yet understand the nuances of CMake, and I am unsure if
some of the items in there need to, or even should, be in there.

Some specific spots of unsureness:
FindNDOF.cmake
   What does the mark_as_advanced() function do, and is it needed?

NDOF.cmake
   I changed the logic of the IF statements.  I THINK that what I wrote is
equivalent, if cleaner.  But I don't know for sure that (NOT WINDOWS) is
equal to (DARWIN OR LINUX) in this case...  (Note that there is no explicit
test for (NOT WINDOWS), there IS however, an "if (WINDOWS) ... else ..."
that is therefor roughly the same logic...)

Both files:
   Where should the library file be stored?  I have currently targeted
${LIBS_PREBUILT_DIR}/include/ndofdev  but I'm fairly sure that this is NOT
the proper place for it.  Standalone mode already goes looking in the system
folders, but I'd like to have a nicely defined location for non-standalone
builds.


This isn't a large patch by any measure, but I'd like to make it correct,
and I'd love to understand all it's nuances and permutations.

Also, if someone could point me to where I should look for making the system
pull down and compile the ndofdev library so I don't have to do that
manually every time I'd be grateful.

Thanks,
Ricky
aka Cron Stardust
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/sldev/attachments/20090106/8bda8a91/attachment.htm