[sldev] Request For Comments on the patch in VWR-10579

[Paul Oppenheim (Poppy Linden)]

Ricky wrote:
>    What does the mark_as_advanced() function do, and is it needed?

Hides a var from showing up in ccmake.

> is equivalent, if cleaner.  But I don't know for sure that (NOT WINDOWS) 
> is equal to (DARWIN OR LINUX) in this case...  (Note that there is no 

Nope. We have a SOLARIS tag too, and could have any platform tag in the future. In general, mean what you write in conditionals, optimizing cmake with a shortcut like this creates no benefit. (Ideally we'd have feature tags and not platforms, which would create more verbose conditionals, but more compatible...)

> Both files:
>    Where should the library file be stored?  I have currently targeted 
> ${LIBS_PREBUILT_DIR}/include/ndofdev  but I'm fairly sure that this is 
> NOT the proper place for it.  Standalone mode already goes looking in 
> the system folders, but I'd like to have a nicely defined location for 
> non-standalone builds.

Look for ARCH_PREBUILT_DIRS. I'm not sure what you want to do exactly, so I can't be more specific than that.


> This isn't a large patch by any measure, but I'd like to make it 
> correct, and I'd love to understand all it's nuances and permutations.
> 
> Also, if someone could point me to where I should look for making the 
> system pull down and compile the ndofdev library so I don't have to do 
> that manually every time I'd be grateful.

I'm not sure what you mean by this. Automatic svn co and make? You could write a python script and source it, but that'd be a real PITA. I'd suggest going with the install.py method, which I'm also hazy about, but that assumes you're OK with not building from source each time.

HTH,

+ poppy