[sldev] Code review for those of you with commit access

Philip Rosedale philip at lindenlab.com
Mon Mar 30 20:22:56 PDT 2009


Very cool to see this all starting! 

 From my perspective, the most important thing to communicate is that if 
you are a committer, you now bear the responsibility of checking in only 
high quality, well tested, sensible work.   Solid design, development, 
and QA is ultimately the final responsibility of the person who hits the 
enter key and checks in code.   Do not count on LL (or anyone else) to 
do that work for you. 

P

Soft wrote:
> On Mon, Mar 30, 2009 at 7:23 PM, Rob Lanphier <robla at lindenlab.com> wrote:
>   
>> Hi folks,
>>
>> As you probably saw in Philip's blog post (which if you haven't read it,
>> do so[1]), we're going to be doing a lot more development out in the
>> fishbowl, in a branch with community members who have direct commit access.
>>
>> There's a few of you that already have commit access, and others that I
>> imagine will be asking for it.  Here's the procedure we'd like to follow
>> for commits for new committers to the http-texture:
>>
>> *  File the patch in JIRA if it isn't already there
>> *  Mail sldev with a link to the JIRA issue, and noting you'd like to
>> commit the patch
>> *  Nag me in a couple of days if we haven't responded
>> *  Assuming you get the nod, commit the change
>>
>> This isn't set in stone....there's a number of aspects about this
>> process I'm going to guess we haven't thought of.  We want to be nimble,
>> but we also want to make sure there's lots of eyeballs on every commit.
>>     
>
> And if you do see a patch linked on sldev - assume it's going to land
> in the branch unless you find a problem with it. Silence is consent,
> so follow up on-list with any concerns. Community review is the whole
> point of posting links.
> _______________________________________________
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/SLDev
> Please read the policies before posting to keep unmoderated posting privileges
>   
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/sldev/attachments/20090330/956b5a4b/attachment.htm 


More information about the SLDev mailing list