[sldev] Code review for those of you with commit access

[Kent Quirk (Q Linden)]

On Mar 31, 2009, at 7:45 AM, Argent Stonecutter wrote:

> On 2009-03-30, at 22:22, Philip Rosedale wrote:
>> From my perspective, the most important thing to communicate is that
>> if you are a committer, you now bear the responsibility of checking
>> in only high quality, well tested, sensible work.   Solid design,
>> development, and QA is ultimately the final responsibility of the
>> person who hits the enter key and checks in code.   Do not count on
>> LL (or anyone else) to do that work for you.
>
> There still needs to be someone, or some-ones, eyeballing commits
> (even if after the fact) and doing release tracking and final QA. Open
> source or not, that's still a necessary role. If Linden Labs isn't
> going to do that, then we (SLDEV) need to step up to the plate, each
> of us in the areas we're competent to monitor.

We (Linden Lab) will definitely still be responsible for the quality  
of the code that makes it into our releases. But if people aren't  
doing an adequate job of design, test, and documentation, then it's  
going to make it a lot harder.

Nobody's perfect -- but we're just asking people to think carefully  
about what they're doing and be professional about it. The bigger the  
change, the more eyes you should have on it before it goes in. Write  
test plans and document your intent.

In particular, we're pushing internally toward much more extensive  
unit testing. Once we get some traction and comfort internally, I  
intend to have a public training session to talk about how we're doing  
it and how open source devs can help. Watch this space for more news.

	Q