[sldev] Code review for those of you with commit access

[Philip Rosedale]

I do very much like the idea of folks in dev community also monitoring 
code and changes in their area, as Argent suggests. 

Adding unit and automation tests is going to be important, as Q sez.

We are working on a test for startup time that can be included in build 
results - I want to start graphing any changes to that with every build.

P


Kent Quirk (Q Linden) wrote:
> On Mar 31, 2009, at 7:45 AM, Argent Stonecutter wrote:
>
>   
>> On 2009-03-30, at 22:22, Philip Rosedale wrote:
>>     
>>> From my perspective, the most important thing to communicate is that
>>> if you are a committer, you now bear the responsibility of checking
>>> in only high quality, well tested, sensible work.   Solid design,
>>> development, and QA is ultimately the final responsibility of the
>>> person who hits the enter key and checks in code.   Do not count on
>>> LL (or anyone else) to do that work for you.
>>>       
>> There still needs to be someone, or some-ones, eyeballing commits
>> (even if after the fact) and doing release tracking and final QA. Open
>> source or not, that's still a necessary role. If Linden Labs isn't
>> going to do that, then we (SLDEV) need to step up to the plate, each
>> of us in the areas we're competent to monitor.
>>     
>
> We (Linden Lab) will definitely still be responsible for the quality  
> of the code that makes it into our releases. But if people aren't  
> doing an adequate job of design, test, and documentation, then it's  
> going to make it a lot harder.
>
> Nobody's perfect -- but we're just asking people to think carefully  
> about what they're doing and be professional about it. The bigger the  
> change, the more eyes you should have on it before it goes in. Write  
> test plans and document your intent.
>
> In particular, we're pushing internally toward much more extensive  
> unit testing. Once we get some traction and comfort internally, I  
> intend to have a public training session to talk about how we're doing  
> it and how open source devs can help. Watch this space for more news.
>
> 	Q
>
>
>
> _______________________________________________
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/SLDev
> Please read the policies before posting to keep unmoderated posting privileges
>   
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.secondlife.com/pipermail/sldev/attachments/20090331/cb6a4119/attachment-0001.htm