[sldev] VWR-12775 : Race condition avoidance patch

[Philippe Bossut (Merov Linden)]

Hi Rob,

K, I'm pretty sure it fixes one cause of crashes but not all of them.  
That being said, I'd like to see the crash logs of your crash. I'll  
dig through the crash logger to see if I find something there.

Thanks for kicking the build this morning.

Cheers,
- Merov

On May 8, 2009, at 9:48 AM, Rob Lanphier wrote:

> On 05/07/2009 07:10 PM, Philippe Bossut (Merov Linden) wrote:
>> That one is such a sucker! I spent some time on it this afternoon  
>> and,
>> reading back through Robin's comment and using my recently gained
>> understanding of the llimageworker thread (acquired through the
>> writing of llimageworker_test... hurray for unit tests!... :) ) I
>> think I have a solution to that bug. At least, I wasn't able to repro
>> the crash at all as might as I tried.
>>
>> I committed the patch (svn 2232) but *did not* triggered the builds  
>> so
>> that it gives you time to look into it and weight on the JIRA.
>> Everything is in place to trigger the builds and, if you really don't
>> like it, we can always roll that one back (it's a 1 liner).
>>
>> Let me know what you think.
>>
>> Special thanks BTW on that one to Robin, Khyota, Techwolf and Michael
>> for their help (we're not done yet though guys :) )
>>
>
> Hmmm....I've got no ideas about the merits of the change, which look
> pretty conservative:
> http://svn.secondlife.com/trac/linden/changeset/2232
>
> However, based on the behavior I'm seeing with the newly built viewers
> (I kicked off a build this morning), it doesn't work. I still crash on
> startup unless I clear my cache first.
>
> Build links for the latest build are available below.
>
> Rob
>
> -------- Original Message --------
> Subject: 	[sldev-commits] Successful Build for http-texture (2232)
> Date: 	Fri, 8 May 2009 09:14:44 -0700 (PDT)
> From: 	buildadmin at lindenlab.com
> To: 	sldev-commits at lists.secondlife.com
>
>
>
> Linux:
> http://secondlife.com/developers/opensource/downloads/2009/http-texture/2232/SecondLife-i686-1.23.0.2232.tar.bz2
> http://secondlife.com/developers/opensource/downloads/2009/http-texture/2232/good-build.Linux
>
> Darwin:
> http://secondlife.com/developers/opensource/downloads/2009/http-texture/2232/SecondLife_1_23_0_2232_OSS.dmg
> http://secondlife.com/developers/opensource/downloads/2009/http-texture/2232/good-build.Darwin
>
> CYGWIN:
> http://secondlife.com/developers/opensource/downloads/2009/http-texture/2232/Second_Life_1-23-0-2232_OSS_Setup.exe
> http://secondlife.com/developers/opensource/downloads/2009/http-texture/2232/good-build.CYGWIN
>
> ------------------------------------------------------------------------
> r2230 | merov.linden | 2009-05-07 17:30:22 -0700 (Thu, 07 May 2009)  
> | 2 lines
> Changed paths:
>   M /projects/2009/http-texture
>   M /projects/2009/http-texture/doc/asset_urls.txt
>   M /projects/2009/http-texture/doc/contributions.txt
>   M /projects/2009/http-texture/indra/llcommon/llversionserver.h
>   M /projects/2009/http-texture/indra/llcommon/llversionviewer.h
>   M /projects/2009/http-texture/indra/llimage/CMakeLists.txt
>   M /projects/2009/http-texture/indra/llimage/llimageworker.cpp
>   M /projects/2009/http-texture/indra/llimage/llimageworker.h
>   M /projects/2009/http-texture/indra/newview/CMakeLists.txt
>   M /projects/2009/http-texture/indra/newview/English.lproj/ 
> InfoPlist.strings
>   M /projects/2009/http-texture/indra/newview/Info-SecondLife.plist
>   M /projects/2009/http-texture/indra/newview/installers/windows/ 
> installer_template.nsi
>   M /projects/2009/http-texture/indra/newview/llagent.cpp
>   M /projects/2009/http-texture/indra/newview/llappviewer.cpp
>   M /projects/2009/http-texture/indra/newview/llfloatersnapshot.cpp
>   M /projects/2009/http-texture/indra/newview/llpanelclassified.cpp
>   A /projects/2009/http-texture/indra/newview/lltexturestats.cpp  
> (from /branches/2009/http-texture/indra/newview/lltexturestats.cpp: 
> 2229)
>   A /projects/2009/http-texture/indra/newview/lltexturestats.h  
> (from /branches/2009/http-texture/indra/newview/lltexturestats.h:2229)
>   M /projects/2009/http-texture/indra/newview/llviewermessage.cpp
>   M /projects/2009/http-texture/indra/newview/llviewerstats.cpp
>   M /projects/2009/http-texture/indra/newview/llviewerstats.h
>   M /projects/2009/http-texture/indra/newview/res/viewerRes.rc
>   M /projects/2009/http-texture/indra/newview/skins/default/xui/en- 
> us/floater_preview_existing_landmark.xml
>   M /projects/2009/http-texture/indra/newview/skins/default/xui/en- 
> us/panel_avatar_classified.xml
>   M /projects/2009/http-texture/indra/newview/skins/default/xui/en- 
> us/panel_classified.xml
>   M /projects/2009/http-texture/indra/newview/skins/default/xui/en- 
> us/panel_group_general.xml
>   M /projects/2009/http-texture/indra/newview/skins/default/xui/en- 
> us/panel_preferences_general.xml
>   M /projects/2009/http-texture/indra/newview/skins/default/xui/en- 
> us/panel_preferences_voice.xml
>   M /projects/2009/http-texture/indra/newview/skins/default/xui/es/ 
> floater_about.xml
>   M /projects/2009/http-texture/indra/newview/skins/default/xui/es/ 
> floater_chat_history.xml
>   M /projects/2009/http-texture/indra/newview/skins/default/xui/es/ 
> panel_preferences_audio.xml
>   M /projects/2009/http-texture/indra/newview/skins/default/xui/es/ 
> panel_preferences_chat.xml
>   M /projects/2009/http-texture/indra/newview/skins/default/xui/es/ 
> panel_preferences_general.xml
>   M /projects/2009/http-texture/indra/newview/skins/default/xui/ko/ 
> floater_about.xml
>   M /projects/2009/http-texture/indra/newview/skins/default/xui/ko/ 
> floater_chat_history.xml
>   M /projects/2009/http-texture/indra/newview/skins/default/xui/pl/ 
> floater_about.xml
>   M /projects/2009/http-texture/indra/newview/skins/default/xui/pl/ 
> floater_buy_land.xml
>   M /projects/2009/http-texture/indra/newview/skins/default/xui/pl/ 
> floater_chat_history.xml
>   M /projects/2009/http-texture/indra/newview/skins/default/xui/pt/ 
> floater_about.xml
>   M /projects/2009/http-texture/indra/newview/skins/default/xui/pt/ 
> floater_chat_history.xml
>   M /projects/2009/http-texture/indra/newview/skins/default/xui/pt/ 
> panel_preferences_audio.xml
>   M /projects/2009/http-texture/indra/newview/skins/default/xui/ru/ 
> floater_about.xml
>   M /projects/2009/http-texture/indra/newview/skins/default/xui/ru/ 
> floater_chat_history.xml
>   M /projects/2009/http-texture/indra/newview/skins/default/xui/uk/ 
> floater_chat_history.xml
>   M /projects/2009/http-texture/indra/newview/skins/default/xui/zh/ 
> floater_about.xml
>   M /projects/2009/http-texture/indra/newview/skins/default/xui/zh/ 
> floater_chat_history.xml
>   M /projects/2009/http-texture/install.xml
>
> svn merge -r2162:2229 https://svn.secondlife.com/svn/linden/branches/2009/http-texture
> Update to newest (1.23 RC0 + http-texture)
> ------------------------------------------------------------------------
> r2232 | merov.linden | 2009-05-07 18:52:21 -0700 (Thu, 07 May 2009)  
> | 1 line
> Changed paths:
>   M /projects/2009/http-texture/indra/newview/lltexturefetch.cpp
>
> VWR-12775 : race condition avoidance on decode callback (1 liner).  
> Tested but not reviewed yet!
> ------------------------------------------------------------------------
> _______________________________________________
> Click here to unsubscribe or manage your list subscription:
> /index.html-commits
>
>
>
>
>