[sldev] VWR-12775 : Race condition avoidance patch

Philippe Bossut (Merov Linden) merov at lindenlab.com
Fri May 8 16:29:32 PDT 2009
Previous message: [sldev] VWR-12775 : Race condition avoidance patch
Next message: [sldev] would this help with increasing the apparent number of light sources at all?
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi,

Well, the patch didn't have the expected result so, in order to see if  
patching the problematic responder helps, I committed the old patch  
(svn 2235) on top of the change I committed yesterday. Builds are  
under way and should be available in a short while (Mac and Linux  
already completed successfully and I'm expecting Windows to clear up  
soon). I'll post again when URLs become available. We'll see if that  
bring the crash rate down a bit.

Discussing with steve this afternoon, he agreed that the best we  
should be doing to improve the reliability of that new code base is to  
put most of it under unit test and document it. I did some of it last  
week, adding unit tests to llimage/llimageworker.cpp. Las, I realized  
that I forgot to modify the export script so the unit tests never made  
it to branches/http-texture. I fixed that with CG this afternoon and,  
next export, we should get them.

Writing unit tests is finicky so it's better to start with some  
example and doc. I've been working with poppy to bring some doc to the  
public wiki. Stay tune for coming links on the subject.

Cheers,
- Merov

On May 8, 2009, at 10:24 AM, Philippe Bossut (Merov Linden) wrote:

> Hi Rob,
>
> K, I'm pretty sure it fixes one cause of crashes but not all of them.
> That being said, I'd like to see the crash logs of your crash. I'll
> dig through the crash logger to see if I find something there.
>
> Thanks for kicking the build this morning.
>
> Cheers,
> - Merov
>
> On May 8, 2009, at 9:48 AM, Rob Lanphier wrote:
>
>> On 05/07/2009 07:10 PM, Philippe Bossut (Merov Linden) wrote:
>>> That one is such a sucker! I spent some time on it this afternoon
>>> and,
>>> reading back through Robin's comment and using my recently gained
>>> understanding of the llimageworker thread (acquired through the
>>> writing of llimageworker_test... hurray for unit tests!... :) ) I
>>> think I have a solution to that bug. At least, I wasn't able to  
>>> repro
>>> the crash at all as might as I tried.
>>>
>>> I committed the patch (svn 2232) but *did not* triggered the builds
>>> so
>>> that it gives you time to look into it and weight on the JIRA.
>>> Everything is in place to trigger the builds and, if you really  
>>> don't
>>> like it, we can always roll that one back (it's a 1 liner).
>>>
>>> Let me know what you think.
>>>
>>> Special thanks BTW on that one to Robin, Khyota, Techwolf and  
>>> Michael
>>> for their help (we're not done yet though guys :) )
>>>
>>
>> Hmmm....I've got no ideas about the merits of the change, which look
>> pretty conservative:
>> http://svn.secondlife.com/trac/linden/changeset/2232
>>
>> However, based on the behavior I'm seeing with the newly built  
>> viewers
>> (I kicked off a build this morning), it doesn't work. I still crash  
>> on
>> startup unless I clear my cache first.
>>
>> Build links for the latest build are available below.
>>
>> Rob
>>
>> -------- Original Message --------
>> Subject: 	[sldev-commits] Successful Build for http-texture (2232)
>> Date: 	Fri, 8 May 2009 09:14:44 -0700 (PDT)
>> From: 	buildadmin at lindenlab.com
>> To: 	sldev-commits at lists.secondlife.com
>>
>>
>>
>> Linux:
>> http://secondlife.com/developers/opensource/downloads/2009/http-texture/2232/SecondLife-i686-1.23.0.2232.tar.bz2
>> http://secondlife.com/developers/opensource/downloads/2009/http-texture/2232/good-build.Linux
>>
>> Darwin:
>> http://secondlife.com/developers/opensource/downloads/2009/http-texture/2232/SecondLife_1_23_0_2232_OSS.dmg
>> http://secondlife.com/developers/opensource/downloads/2009/http-texture/2232/good-build.Darwin
>>
>> CYGWIN:
>> http://secondlife.com/developers/opensource/downloads/2009/http-texture/2232/Second_Life_1-23-0-2232_OSS_Setup.exe
>> http://secondlife.com/developers/opensource/downloads/2009/http-texture/2232/good-build.CYGWIN
>>
>> ------------------------------------------------------------------------
>> r2230 | merov.linden | 2009-05-07 17:30:22 -0700 (Thu, 07 May 2009)
>> | 2 lines
>> Changed paths:
>>  M /projects/2009/http-texture
>>  M /projects/2009/http-texture/doc/asset_urls.txt
>>  M /projects/2009/http-texture/doc/contributions.txt
>>  M /projects/2009/http-texture/indra/llcommon/llversionserver.h
>>  M /projects/2009/http-texture/indra/llcommon/llversionviewer.h
>>  M /projects/2009/http-texture/indra/llimage/CMakeLists.txt
>>  M /projects/2009/http-texture/indra/llimage/llimageworker.cpp
>>  M /projects/2009/http-texture/indra/llimage/llimageworker.h
>>  M /projects/2009/http-texture/indra/newview/CMakeLists.txt
>>  M /projects/2009/http-texture/indra/newview/English.lproj/
>> InfoPlist.strings
>>  M /projects/2009/http-texture/indra/newview/Info-SecondLife.plist
>>  M /projects/2009/http-texture/indra/newview/installers/windows/
>> installer_template.nsi
>>  M /projects/2009/http-texture/indra/newview/llagent.cpp
>>  M /projects/2009/http-texture/indra/newview/llappviewer.cpp
>>  M /projects/2009/http-texture/indra/newview/llfloatersnapshot.cpp
>>  M /projects/2009/http-texture/indra/newview/llpanelclassified.cpp
>>  A /projects/2009/http-texture/indra/newview/lltexturestats.cpp
>> (from /branches/2009/http-texture/indra/newview/lltexturestats.cpp:
>> 2229)
>>  A /projects/2009/http-texture/indra/newview/lltexturestats.h
>> (from /branches/2009/http-texture/indra/newview/lltexturestats.h: 
>> 2229)
>>  M /projects/2009/http-texture/indra/newview/llviewermessage.cpp
>>  M /projects/2009/http-texture/indra/newview/llviewerstats.cpp
>>  M /projects/2009/http-texture/indra/newview/llviewerstats.h
>>  M /projects/2009/http-texture/indra/newview/res/viewerRes.rc
>>  M /projects/2009/http-texture/indra/newview/skins/default/xui/en-
>> us/floater_preview_existing_landmark.xml
>>  M /projects/2009/http-texture/indra/newview/skins/default/xui/en-
>> us/panel_avatar_classified.xml
>>  M /projects/2009/http-texture/indra/newview/skins/default/xui/en-
>> us/panel_classified.xml
>>  M /projects/2009/http-texture/indra/newview/skins/default/xui/en-
>> us/panel_group_general.xml
>>  M /projects/2009/http-texture/indra/newview/skins/default/xui/en-
>> us/panel_preferences_general.xml
>>  M /projects/2009/http-texture/indra/newview/skins/default/xui/en-
>> us/panel_preferences_voice.xml
>>  M /projects/2009/http-texture/indra/newview/skins/default/xui/es/
>> floater_about.xml
>>  M /projects/2009/http-texture/indra/newview/skins/default/xui/es/
>> floater_chat_history.xml
>>  M /projects/2009/http-texture/indra/newview/skins/default/xui/es/
>> panel_preferences_audio.xml
>>  M /projects/2009/http-texture/indra/newview/skins/default/xui/es/
>> panel_preferences_chat.xml
>>  M /projects/2009/http-texture/indra/newview/skins/default/xui/es/
>> panel_preferences_general.xml
>>  M /projects/2009/http-texture/indra/newview/skins/default/xui/ko/
>> floater_about.xml
>>  M /projects/2009/http-texture/indra/newview/skins/default/xui/ko/
>> floater_chat_history.xml
>>  M /projects/2009/http-texture/indra/newview/skins/default/xui/pl/
>> floater_about.xml
>>  M /projects/2009/http-texture/indra/newview/skins/default/xui/pl/
>> floater_buy_land.xml
>>  M /projects/2009/http-texture/indra/newview/skins/default/xui/pl/
>> floater_chat_history.xml
>>  M /projects/2009/http-texture/indra/newview/skins/default/xui/pt/
>> floater_about.xml
>>  M /projects/2009/http-texture/indra/newview/skins/default/xui/pt/
>> floater_chat_history.xml
>>  M /projects/2009/http-texture/indra/newview/skins/default/xui/pt/
>> panel_preferences_audio.xml
>>  M /projects/2009/http-texture/indra/newview/skins/default/xui/ru/
>> floater_about.xml
>>  M /projects/2009/http-texture/indra/newview/skins/default/xui/ru/
>> floater_chat_history.xml
>>  M /projects/2009/http-texture/indra/newview/skins/default/xui/uk/
>> floater_chat_history.xml
>>  M /projects/2009/http-texture/indra/newview/skins/default/xui/zh/
>> floater_about.xml
>>  M /projects/2009/http-texture/indra/newview/skins/default/xui/zh/
>> floater_chat_history.xml
>>  M /projects/2009/http-texture/install.xml
>>
>> svn merge -r2162:2229 https://svn.secondlife.com/svn/linden/branches/2009/http-texture
>> Update to newest (1.23 RC0 + http-texture)
>> ------------------------------------------------------------------------
>> r2232 | merov.linden | 2009-05-07 18:52:21 -0700 (Thu, 07 May 2009)
>> | 1 line
>> Changed paths:
>>  M /projects/2009/http-texture/indra/newview/lltexturefetch.cpp
>>
>> VWR-12775 : race condition avoidance on decode callback (1 liner).
>> Tested but not reviewed yet!
>> ------------------------------------------------------------------------
>> _______________________________________________
>> Click here to unsubscribe or manage your list subscription:
>> /index.html-commits
>>
>>
>>
>>
>>
>
> _______________________________________________
> Policies and (un)subscribe information available here:
> http://wiki.secondlife.com/wiki/SLDev
> Please read the policies before posting to keep unmoderated posting  
> privileges
Previous message: [sldev] VWR-12775 : Race condition avoidance patch
Next message: [sldev] would this help with increasing the apparent number of light sources at all?
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
More information about the SLDev mailing list